Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make update-otel #9427

Merged
merged 2 commits into from Apr 26, 2022
Merged

Conversation

codeboten
Copy link
Contributor

Updating core to prepare for release later this week.

Updating core to prepare for release later this week.
@pmm-sumo
Copy link
Contributor

Seems this test has some problems:

make -C ./receiver/cloudfoundryreceiver test
make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/cloudfoundryreceiver'
go test -race -v -timeout 300s --tags="" ./...
=== RUN   TestLoadConfig
--- PASS: TestLoadConfig (0.01s)
=== RUN   TestLoadInvalidConfig
--- PASS: TestLoadInvalidConfig (0.00s)
=== RUN   TestInvalidConfigValidation
--- PASS: TestInvalidConfigValidation (0.00s)
=== RUN   TestHTTPConfigurationStructConsistency
    config_test.go:148: 
        	Error Trace:	config_test.go:148
        	            				config_test.go:110
        	Error:      	Not equal: 
        	            	expected: "mapstructure:\"tls,omitempty\""
        	            	actual  : "mapstructure:\"tls\""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,2 @@
        	            	-(reflect.StructTag) (len=28) "mapstructure:\"tls,omitempty\""
        	            	+(reflect.StructTag) (len=18) "mapstructure:\"tls\""
        	            	 
        	Test:       	TestHTTPConfigurationStructConsistency
        	Messages:   	field TLSSetting tag match
--- FAIL: TestHTTPConfigurationStructConsistency (0.00s)

@jpkrohling
Copy link
Member

This is probably related to open-telemetry/opentelemetry-collector#5256

cc @bogdandrutu

@codeboten
Copy link
Contributor Author

@jpkrohling @pmm-sumo fixed the test

@jpkrohling
Copy link
Member

tracegen check restarted:

 > [build 4/4] RUN CGO_ENABLED=0 go build -o /tracegen:
#14 0.956 go: downloading go.uber.org/multierr v1.8.0
#14 0.985 go: downloading golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4
#14 1.040 go: downloading github.com/go-logr/stdr v1.2.2
#14 1.053 go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.7.0
#14 1.192 go: downloading github.com/cenkalti/backoff/v4 v4.1.2
#14 1.215 go: downloading golang.org/x/text v0.3.5
#14 3.786 /go/pkg/mod/github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0/runtime/handler.go:11:2: google.golang.org/genproto@v0.0.0-20211118181313-81c1377c94b1: stream error: stream ID 1; INTERNAL_ERROR; received from peer
#14 3.786 /go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc@v1.6.1/client.go:23:2: google.golang.org/genproto@v0.0.0-20211118181313-81c1377c94b1: stream error: stream ID 1; INTERNAL_ERROR; received from peer
#14 3.786 /go/pkg/mod/google.golang.org/grpc@v1.45.0/status/status.go:35:2: google.golang.org/genproto@v0.0.0-20211118181313-81c1377c94b1: stream error: stream ID 1; INTERNAL_ERROR; received from peer
#14 3.786 /go/pkg/mod/github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0/runtime/fieldmask.go:9:2: google.golang.org/genproto@v0.0.0-20211118181313-81c1377c94b1: stream error: stream ID 1; INTERNAL_ERROR; received from peer

@jpkrohling jpkrohling merged commit f864126 into open-telemetry:main Apr 26, 2022
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
* make update-otel

Updating core to prepare for release later this week.

* update settings
@codeboten codeboten deleted the codeboten/update-otel-core branch June 8, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants