Do not report fatal error if err is server closed #9559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
occloseerr
branch
2 times, most recently
from
3f511bb
to
0b7e8c7
Compare
Because we use the cmux, closing the listener causes the cmux to close which will cause the grpc/http servers to also close with a `cmux.ErrServerClosed` error. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
dmitryax
approved these changes
Apr 29, 2022
codeboten
approved these changes
May 3, 2022
codeboten
added
the
ready to merge
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
Because we use the cmux, closing the listener causes the cmux to close which will cause the grpc/http servers to also close with a `cmux.ErrServerClosed` error. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we use the cmux, closing the listener causes the cmux to close which will cause the grpc/http servers to also close with a
cmux.ErrServerClosederror.Fixes open-telemetry/opentelemetry-collector#5261
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com