-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies to add GCP cloud logging exporter #9679
Bump dependencies to add GCP cloud logging exporter #9679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is adding new functionality to the exporter, please add a note to the changelog
@codeboten I updated the changelog, is there anything I need to do to get the tests to run again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codeboten I updated the changelog, is there anything I need to do to get the tests to run again?
The test run automatically on every commit so you should be ok there. Please resolve the conflicts and we'll get this merged 👍
0563c7e
to
14d1834
Compare
Updated, thanks. btw it looks like first-time contributors need a maintainer to approve the workflows, at least that's the message I see. Just a heads up in case that's an unintentional setting |
b9d789e
to
3218558
Compare
3218558
to
4fb99ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests are still failing:
make -C ./exporter/googlecloudexporter test
make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/googlecloudexporter'
go test -race -v -timeout 300s --tags="" ./...
=== RUN TestLoadConfig
config_test.go:60:
Error Trace: config_test.go:60
Error: Not equal:
expected: &googlecloudexporter.Config{ExporterSettings:config.ExporterSettings{id:config.ComponentID{typeVal:"googlecloud", nameVal:"customname"}}, Config:collector.Config{ProjectID:"my-project", UserAgent:"opentelemetry-collector-contrib {{version}}", TraceConfig:collector.TraceConfig{ClientConfig:collector.ClientConfig{Endpoint:"test-trace-endpoint", UseInsecure:true, GetClientOptions:(func() []option.ClientOption)(nil)}, AttributeMappings:[]collector.AttributeMapping(nil)}, MetricConfig:collector.MetricConfig{ClientConfig:collector.ClientConfig{Endpoint:"test-metric-endpoint", UseInsecure:true, GetClientOptions:(func() []option.ClientOption)(nil)}, Prefix:"prefix", SkipCreateMetricDescriptor:true, KnownDomains:[]string{"googleapis.com", "kubernetes.io", "istio.io", "knative.dev"}, InstrumentationLibraryLabels:true, CreateServiceTimeSeries:false, CreateMetricDescriptorBufferSize:10, ServiceResourceLabels:true, ResourceFilters:[]collector.ResourceFilter(nil), CumulativeNormalization:true, EnableSumOfSquaredDeviation:false}, LogConfig:collector.LogConfig{ClientConfig:collector.ClientConfig{Endpoint:"", UseInsecure:false, GetClientOptions:(func() []option.ClientOption)(nil)}, DefaultLogName:""}}, TimeoutSettings:exporterhelper.TimeoutSettings{Timeout:20000000000}, QueueSettings:exporterhelper.QueueSettings{Enabled:true, NumConsumers:2, QueueSize:10}, RetrySettings:exporterhelper.RetrySettings{Enabled:true, InitialInterval:10000000000, MaxInterval:60000000000, MaxElapsedTime:600000000000}}
actual : &googlecloudexporter.Config{ExporterSettings:config.ExporterSettings{id:config.ComponentID{typeVal:"googlecloud", nameVal:"customname"}}, Config:collector.Config{ProjectID:"my-project", UserAgent:"opentelemetry-collector-contrib {{version}}", TraceConfig:collector.TraceConfig{ClientConfig:collector.ClientConfig{Endpoint:"test-trace-endpoint", UseInsecure:true, GetClientOptions:(func() []option.ClientOption)(nil)}, AttributeMappings:[]collector.AttributeMapping(nil)}, MetricConfig:collector.MetricConfig{ClientConfig:collector.ClientConfig{Endpoint:"test-metric-endpoint", UseInsecure:true, GetClientOptions:(func() []option.ClientOption)(nil)}, Prefix:"prefix", SkipCreateMetricDescriptor:true, KnownDomains:[]string{"googleapis.com", "kubernetes.io", "istio.io", "knative.dev"}, InstrumentationLibraryLabels:true, CreateServiceTimeSeries:false, CreateMetricDescriptorBufferSize:10, ServiceResourceLabels:true, ResourceFilters:[]collector.ResourceFilter(nil), CumulativeNormalization:false, EnableSumOfSquaredDeviation:false}, LogConfig:collector.LogConfig{ClientConfig:collector.ClientConfig{Endpoint:"", UseInsecure:false, GetClientOptions:(func() []option.ClientOption)(nil)}, DefaultLogName:""}}, TimeoutSettings:exporterhelper.TimeoutSettings{Timeout:20000000000}, QueueSettings:exporterhelper.QueueSettings{Enabled:true, NumConsumers:2, QueueSize:10}, RetrySettings:exporterhelper.RetrySettings{Enabled:true, InitialInterval:10000000000, MaxInterval:60000000000, MaxElapsedTime:600000000000}}
Diff:
--- Expected
+++ Actual
@@ -37,3 +37,3 @@
ResourceFilters: ([]collector.ResourceFilter) <nil>,
- CumulativeNormalization: (bool) true,
+ CumulativeNormalization: (bool) false,
EnableSumOfSquaredDeviation: (bool) false
Test: TestLoadConfig
--- FAIL: TestLoadConfig (0.01s)
=== RUN TestCreateDefaultConfig
factory_test.go:31:
Error Trace: factory_test.go:31
Error: Received unexpected error:
type "Config" from package "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter" has invalid config settings: type "Config" from package "github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector" has invalid config settings: type "MetricConfig" from package "github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector" has invalid config settings: mapstructure tag not present on field "EnableSumOfSquaredDeviation"
Test: TestCreateDefaultConfig
4fb99ef
to
d4b0bc5
Compare
Updated to pull in test fix from GoogleCloudPlatform/opentelemetry-operations-go#380 |
d4b0bc5
to
a1b0290
Compare
Co-authored-by: Alex Boten <aboten@lightstep.com>
Description:
This imports an exporter for GCP logs
Link to tracking Issue: #8249
Testing: Manual and automated unit and integration tests in GoogleCloudPlatform/opentelemetry-operations-go
Documentation: Readme updated with new fields and sample configs