[receiver/mysql] Fix attribute values mismatch with its definition #9688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djaglowski please let me know if this is the right way to fix it or we should update metadata.yaml instead |
Some attribute are emitted with values different from what's defined in metadata.yaml. This fix takes metadata.yaml definition as a source of truth and updates the emitted data
dmitryax
force-pushed
the
fix-mysql-attribute-values
branch
from
e1f2f5f
to
f83f26f
Compare
djaglowski
approved these changes
May 3, 2022
There was a problem hiding this comment.
Although I'd generally prefer to maintain backwards compatibility where possible, it does seem that important context was lost in the initial implementation. There is currently no mechanism to further describe the meaning of the enumerated values, so I think it is important that the names are communicative.
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…pen-telemetry#9688) Some attribute are emitted with values different from what's defined in metadata.yaml. This fix takes metadata.yaml definition as a source of truth and updates the emitted data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some attribute are emitted with values different from what's defined in metadata.yaml. This fix takes metadata.yaml definition as a source of truth and updates the emitted data