[receiver\sqlserver] Fix SQL Server metrics to have int type where appropriate #9691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
force-pushed
the
sqlserver_metric_types
branch
from
2e30c14
to
58c5c2e
Compare
|
@StefanKurek, please rebase. #9694 should resolve the issue. |
Change the following metrics from double type to int: sqlserver.transaction_log.usage sqlserver.transaction_log.shrink.count sqlserver.transaction_log.growth.count sqlserver.page.life_expectancy sqlserver.user.connection.count
StefanKurek
force-pushed
the
sqlserver_metric_types
branch
from
58c5c2e
to
4d1fe32
Compare
djaglowski
approved these changes
May 3, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…-telemetry#9691) Change the following metrics from double type to int: sqlserver.transaction_log.usage sqlserver.transaction_log.shrink.count sqlserver.transaction_log.growth.count sqlserver.page.life_expectancy sqlserver.user.connection.count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some of the metrics that this receiver collects are only ever integers even though they are currently marked as doubles.
This PR changes the following metrics from double type to int:
sqlserver.transaction_log.usage
sqlserver.transaction_log.shrink.count
sqlserver.transaction_log.growth.count
sqlserver.page.life_expectancy
sqlserver.user.connection.count
Issue: #9601
Testing: Manually ran and verified that changed metrics came back as integers instead of doubles.
Documentation: Updated documentation to reflect metric changes