enable errcheck and exclude all components which are not passing. #9726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatsheep9146
requested review from
a team,
jpkrohling,
djaglowski,
jmacd,
dmitryax,
pmm-sumo,
Aneurysm9,
dashpole,
mx-psi,
punya,
jsuereth and
arminru
as code owners
fatsheep9146
force-pushed
the
fatsheep9146/add-linter-errcheck
branch
from
86847f4
to
607fee1
Compare
dashpole
approved these changes
May 4, 2022
…h are not passing. Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
fatsheep9146
force-pushed
the
fatsheep9146/add-linter-errcheck
branch
from
9f6f6b6
to
4307761
Compare
82 tasks
mx-psi
approved these changes
May 5, 2022
There was a problem hiding this comment.
LGTM! I created #9749 for the follow up work. Feel free to do as much or as little from the list as you want, otherwise each of the component's owners can also tackle their own component's issues.
Also, I would like to keep #9109 open, since it also refers to other linters. Could you change your PR description so that it fixes #9750 instead?
No problem, I've already changed comments. |
mx-psi
added
the
ready to merge
pmm-sumo
approved these changes
May 5, 2022
djaglowski
approved these changes
May 5, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 5, 2022
…en-telemetry#9726) * add errcheck to golangci-lint config, and exclude all components which are not passing. Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * fix missing issues for linux Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * fix missing issues for linux Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…en-telemetry#9726) * add errcheck to golangci-lint config, and exclude all components which are not passing. Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * fix missing issues for linux Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * fix missing issues for linux Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix #9750 as @mx-psi suggested, first enable
errcheckand exclude all components that are not passing right now.Link to tracking Issue:
#9750
Signed-off-by: Ziqi Zhao zhaoziqi9146@gmail.com