[exporter/prometheusremotewriteexporter] Do not modify attributes Map in prometheusRW #9736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying data in the prometheus remote write causes a race when more than one exporters is accessing data. To avoid this, all operations are done on cloned data.
|
|
|
Will sort out the CLA stuff soon. |
dashpole
approved these changes
May 5, 2022
codeboten
approved these changes
May 5, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
… in prometheusRW (open-telemetry#9736) * Do not modify attributes Map in prometheusRW Modifying data in the prometheus remote write causes a race when more than one exporters is accessing data. To avoid this, all operations are done on cloned data. * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Modifying data in the prometheus remote write causes a race when more
than one exporters is accessing data.
To avoid this, all operations are done on cloned data.
Link to tracking Issue: #9727
Testing:
I have executed the reproduction steps described in the bug report. With the fix the panic is not occurring anymore.
Documentation:
Added inline comment about the change as this is not self-explanatory.