[receiver/mongodb] Use metrics builder for resource metrics #9759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors the receiver to rely more on generated code. The only functional change: Metrics scope name is changed from `otelcol/mongodb` to `otelcol/mongodbreceiver`
|
Another issue uncovered after this change: #9760 |
djaglowski
approved these changes
May 5, 2022
dmitryax
added
the
ready to merge
codeboten
reviewed
May 5, 2022
| database: | ||
| description: The name of a database. | ||
| type: string | ||
|
|
||
| attributes: | ||
| database: |
There was a problem hiding this comment.
Is it expected to have the attribute and resource_attribute be a duplicate of one another?
There was a problem hiding this comment.
Yes, this is current behavior. I submitted a separate issue to address that #9760
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…emetry#9759) This change refactors the receiver to rely more on generated code. The only functional change: Metrics scope name is changed from `otelcol/mongodb` to `otelcol/mongodbreceiver`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the receiver to rely more on generated code.
The only functional change:
Metrics scope name is changed from
otelcol/mongodbtootelcol/mongodbreceiver