[Makefile] Fix issues with common targets #9775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/easycla |
codeboten
approved these changes
May 9, 2022
bogdandrutu
reviewed
May 9, 2022
| @@ -37,7 +37,11 @@ all-modules: | |||
| @echo $(ALL_MODULES) | tr ' ' '\n' | sort | |||
|
|
|||
| .PHONY: all | |||
| all: common gotest otelcontribcol otelcontribcol-unstable | |||
| all: all-common gotest otelcontribcol otelcontribcol-unstable | |||
There was a problem hiding this comment.
what is the rule between common and non-common? Should test be there as well?
There was a problem hiding this comment.
I see your point. It's not very consistent. I will write up a new issue to proposal guidelines on how targets should be scoped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9763
Summary of changes, including a few minor related issues:
ALL_PKG_DIRSusesgo listto find the directories corresponding to packages of the current module only.ALL_SRCchanged to find.gofiles of the current module only.ALL_PKGS, which was erroring out silently because it depended onGOCMDtoo early.commonfor the root module. Now runscommonfor all modules.checkdocfrom per-module make file, as this only needs to run at the root.