Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lint] Fix / ignore some lint issues resulting from deprecations in 1.18 #9782

Merged
merged 2 commits into from
May 9, 2022
Merged

[lint] Fix / ignore some lint issues resulting from deprecations in 1.18 #9782

merged 2 commits into from
May 9, 2022

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented May 6, 2022 •
edited

strings.Title() and net.Error.Temporary() are deprecated in 1.18. Neither appears to be an urgent concern, so just ignoring them.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 6, 2022
@djaglowski djaglowski marked this pull request as ready for review May 9, 2022 14:38
@djaglowski djaglowski requested review from a team, jmacd and dmitryax as code owners May 9, 2022 14:38
@dmitryax
Copy link
Member

dmitryax commented May 9, 2022 •
edited

Should we have an issue to replace them?

This was referenced May 9, 2022
Closed
Closed
Closed
Closed
@djaglowski djaglowski merged commit 10612c4 into open-telemetry:main May 9, 2022
@djaglowski djaglowski deleted the lint-1.18 branch May 9, 2022 17:05
djaglowski added a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
@djaglowski
[lint] Fix / ignore some lint issues resulting from deprecations in 1…
58c4b8b 
….18 (open-telemetry#9782)

* [lint] Fix / ignore some lint issues resulting from deprecations in 1.18

* Ignore strings.Title
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
@pavankrish123 pavankrish123 mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

Assignees

@dmitryax dmitryax

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djaglowski @dmitryax