[exporter/datadog] Fix canceling on createTracesExporter
#9797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
added
the
release:blocker
|
I am marking this as a blocker since it affects the Datadog exporter functionality in a bad way (missing host metadata, which can result in missing tags and incorrect dimensions). |
|
Ci failure is unrelated: trying to fix on #9799 |
KSerrania
approved these changes
May 9, 2022
mx-psi
added
the
ready to merge
|
@djaglowski we need this to be merged before Wednesday, since this addresses an important bug that would land on the next release otherwise. Could you have a look? |
bogdandrutu
approved these changes
May 9, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug introduced in #9426 where a context is incorrectly canceled via
deferinstead of being canceled only when the function errors out.It was spotted by @gbbr on #9426 (comment).
Since this has not been out on any release, no changelog note is needed.