Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Split core and contrib workflows #477

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Feb 14, 2024

This PR separates the Core and Contrib distributions into separate workflows.

The repository continues to use a single goreleaser.yaml file because:

  1. we already have a process to generate it
  2. goreleaser has features to support a single file

We specifically take advantage of id to specify exactly which things in the goreleaser.yaml file get built.

For now I did not change the triggers - both sets of workflows will currently always be triggered at the same time, like they are today.

Related to #429

Example workflows:

I couldn't test the actual release bc I don't have a goreleaser-pro key.

@TylerHelmuth
Copy link
Member Author

Created #478 to take care of ensuring partial is included in the generate.

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks mostly right, but there are a few cosign-related changes that seem misplaced.

.github/workflows/base-release.yaml Show resolved Hide resolved
.github/workflows/base-release.yaml Outdated Show resolved Hide resolved
.github/workflows/base-release.yaml Outdated Show resolved Hide resolved
.github/workflows/base-release.yaml Outdated Show resolved Hide resolved
@TylerHelmuth
Copy link
Member Author

@jpkrohling all those downgrades were the result of a bad merge. Should now be fixed.

@jpkrohling jpkrohling merged commit 491aecf into open-telemetry:main Feb 19, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants