Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loadbalancer version, not officially supported #5

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team as a code owner August 31, 2021 22:18
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it serves as an example of how to add an extra distribution. Instead of removing it entirely, can we instead add -contrib?

@bogdandrutu
Copy link
Member Author

-contrib is the full version and we will do that from here as well next

@jpkrohling jpkrohling merged commit 54b03e2 into open-telemetry:main Sep 1, 2021
@jpkrohling
Copy link
Member

Alright, I'm merging this as it'll still be fresh in memory by the time we add contrib.

OverOrion added a commit to OverOrion/opentelemetry-collector-releases that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants