Use git tags for 0.34.0 release #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
force-pushed
the
jpkrohling/issue6
branch
from
c8660b1
to
d8680a9
Compare
jpkrohling
commented
Sep 2, 2021
| - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/opencensusreceiver 9b0e90027913f53d4231eb1762063cf67df61051 | ||
| - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver 9b0e90027913f53d4231eb1762063cf67df61051 | ||
| - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zipkinreceiver 9b0e90027913f53d4231eb1762063cf67df61051 | ||
| - import: go.opentelemetry.io/collector/receiver/otlpreceiver |
There was a problem hiding this comment.
Components that are part of the core should be specified only if the distribution has a "include_core: false" option. Otherwise, all core components are being included. Adding it here as well causes runtime errors like this:
2021/09/02 20:49:31 failed to build components: [duplicate extension factory "zpages"; duplicate receiver factory "otlp"; duplicate exporter factory "logging"; duplicate processor factory "batch"]
|
This PR requires #11 to be merged. |
Fixes #6 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/issue6
branch
from
d8680a9
to
63ee262
Compare
bogdandrutu
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de