[manifests] Remove unnecessary replaces #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would feel more comfortable if we had #85 first before this, but in principle it should be safe |
jpkrohling
reviewed
Mar 21, 2022
| - github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/cwlogs => github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/cwlogs v0.47.0 | ||
| - github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/ecsutil => github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/ecsutil v0.47.0 | ||
| - github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal => github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal v0.47.0 | ||
| - github.com/open-telemetry/opentelemetry-collector-contrib/internal/sharedcomponent => github.com/open-telemetry/opentelemetry-collector-contrib/internal/sharedcomponent v0.47.0 | ||
| - github.com/googleapis/gnostic v0.5.6 => github.com/googleapis/gnostic v0.5.5 |
There was a problem hiding this comment.
What do you think about requiring replaces to be justified? Like, why should this one on gnostic be kept?
There was a problem hiding this comment.
That makes sense to me, I think for gnostic it was copied from here https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/459a4bc12e5d538a175dd20a9c0319241c9e1a96/go.mod#L791-L792 but from reading the issue google/gnostic#262 I think we can also remove it, both here and in contrib
There was a problem hiding this comment.
I was wrong, it's still needed. I added a comment to document it
jpkrohling
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Remove
replacedirectives that are no longer necessary.They were added by @svrakitin in #62, but can now be removed according to #62 (comment)