Skip to content

Commit

Permalink
Verify ConfigProvider and ConfigProviderSettings aren't both passed
Browse files Browse the repository at this point in the history
  • Loading branch information
evan-bradley committed Feb 15, 2024
1 parent d07ab41 commit 5494cfb
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
6 changes: 6 additions & 0 deletions otelcol/collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ package otelcol // import "go.opentelemetry.io/collector/otelcol"

import (
"context"
"errors"
"fmt"
"os"
"os/signal"
Expand Down Expand Up @@ -120,6 +121,11 @@ func NewCollector(set CollectorSettings) (*Collector, error) {
if err != nil {
return nil, err
}
} else {
resolverSettings := set.ConfigProviderSettings.ResolverSettings
if len(resolverSettings.Converters) != 0 || len(resolverSettings.Providers) != 0 || len(resolverSettings.URIs) != 0 {
return nil, errors.New("only one of ConfigProvider or ConfigProviderSettings may be specified")
}
}

state := &atomic.Int32{}
Expand Down
12 changes: 12 additions & 0 deletions otelcol/collector_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,18 @@ func TestCollectorStartInvalidConfig(t *testing.T) {
assert.Error(t, col.Run(context.Background()))
}

func TestNewCollectorCantSpecifyBothConfigProviderAndSettings(t *testing.T) {
configProvider, err := NewConfigProvider(newDefaultConfigProviderSettings([]string{"otelcol-nop.yaml"}))
require.NoError(t, err)
_, err = NewCollector(CollectorSettings{
BuildInfo: component.NewDefaultBuildInfo(),
Factories: nopFactories,
ConfigProvider: configProvider,
ConfigProviderSettings: newDefaultConfigProviderSettings([]string{filepath.Join("testdata", "otelcol-invalid.yaml")}),
})
require.Error(t, err)
}

func TestNewCollectorInvalidConfigProviderSettings(t *testing.T) {
_, err := NewCollector(CollectorSettings{
BuildInfo: component.NewDefaultBuildInfo(),
Expand Down

0 comments on commit 5494cfb

Please sign in to comment.