Address feedback

open-telemetry · Jun 10, 2020 · c0d3146 · c0d3146
1 parent 6e29eaf
commit c0d3146
Show file tree

Hide file tree

Showing 11 changed files with 16 additions and 12 deletions.
diff --git a/exporter/opencensusexporter/README.md b/exporter/opencensusexporter/README.md
@@ -28,7 +28,7 @@ Example:
 ```yaml
 exporters:
   opencensus:
-    endpoint: localhost:14250
+    endpoint: 0.0.0.0:14250
     reconnection_delay: 60s
     secure: false
 ```

diff --git a/exporter/otlpexporter/README.md b/exporter/otlpexporter/README.md
@@ -28,7 +28,7 @@ Example:
 ```yaml
 exporters:
   otlp:
-    endpoint: localhost:14250
+    endpoint: 0.0.0.0:14250
     reconnection_delay: 60s
     secure: false
 ```

diff --git a/extension/pprofextension/config.go b/extension/pprofextension/config.go
@@ -24,6 +24,8 @@ type Config struct {
 	configmodels.ExtensionSettings `mapstructure:",squash"`
 
 	// Endpoint is the address and port in which the pprof will be listening to.
+    // Use localhost:<port> to make it available only locally, or ":<port>" to
+    // make it available on all network interfaces.
 	Endpoint string `mapstructure:"endpoint"`
 
 	// Fraction of blocking events that are profiled. A value <= 0 disables

diff --git a/extension/pprofextension/factory.go b/extension/pprofextension/factory.go
@@ -44,7 +44,7 @@ func (f *Factory) CreateDefaultConfig() configmodels.Extension {
 			TypeVal: typeStr,
 			NameVal: typeStr,
 		},
-		Endpoint: "0.0.0.0:1777",
+		Endpoint: "localhost:1777",
 	}
 }
 

diff --git a/extension/pprofextension/factory_test.go b/extension/pprofextension/factory_test.go
@@ -42,7 +42,7 @@ func TestFactory_CreateDefaultConfig(t *testing.T) {
 			NameVal: typeStr,
 			TypeVal: typeStr,
 		},
-		Endpoint: "0.0.0.0:1777",
+		Endpoint: "localhost:1777",
 	},
 		cfg)
 

diff --git a/extension/zpagesextension/config.go b/extension/zpagesextension/config.go
@@ -23,5 +23,7 @@ type Config struct {
 	configmodels.ExtensionSettings `mapstructure:",squash"`
 
 	// Endpoint is the address and port in which the zPages will be listening to.
+    // Use localhost:<port> to make it available only locally, or ":<port>" to
+    // make it available on all network interfaces.
 	Endpoint string `mapstructure:"endpoint"`
 }
diff --git a/extension/zpagesextension/factory.go b/extension/zpagesextension/factory.go
@@ -44,7 +44,7 @@ func (f *Factory) CreateDefaultConfig() configmodels.Extension {
 			TypeVal: typeStr,
 			NameVal: typeStr,
 		},
-		Endpoint: "0.0.0.0:55679",
+		Endpoint: "localhost:55679",
 	}
 }
 

diff --git a/extension/zpagesextension/factory_test.go b/extension/zpagesextension/factory_test.go
@@ -42,7 +42,7 @@ func TestFactory_CreateDefaultConfig(t *testing.T) {
 			NameVal: typeStr,
 			TypeVal: typeStr,
 		},
-		Endpoint: "0.0.0.0:55679",
+		Endpoint: "localhost:55679",
 	},
 		cfg)
 

diff --git a/receiver/jaegerreceiver/README.md b/receiver/jaegerreceiver/README.md
@@ -37,7 +37,7 @@ receivers:
         tls_credentials:
           key_file: /key.pem # path to private key
           cert_file: /cert.pem # path to certificate
-        endpoint: "localhost:9876"
+        endpoint: "0.0.0.0:9876"
 ```
 
 ## Remote Sampling

diff --git a/receiver/opencensusreceiver/README.md b/receiver/opencensusreceiver/README.md
@@ -43,7 +43,7 @@ specifying a list of allowed CORS origins in the `cors_allowed_origins` field:
 ```yaml
 receivers:
   opencensus:
-    endpoint: "localhost:55678"
+    endpoint: "0.0.0.0:55678"
     cors_allowed_origins:
     - http://test.com
     # Origins can have wildcards with *, use * by itself to match any origin.

diff --git a/receiver/prometheusreceiver/README.md b/receiver/prometheusreceiver/README.md
@@ -555,11 +555,11 @@ receivers:
           - job_name: 'opencensus_service'
             scrape_interval: 5s
             static_configs:
-              - targets: ['localhost:8889']
+              - targets: ['0.0.0.0:8889']
           - job_name: 'jdbc_apps'
             scrape_interval: 3s
             static_configs:
-              - targets: ['localhost:9777']
+              - targets: ['0.0.0.0:9777']
 ```
 
 ### Include Filter
@@ -577,8 +577,8 @@ of the metrics from the targets will be dropped.
 receivers:
     prometheus:
       include_filter: {
-        "localhost:9777" : [http/server/server_latency, custom_metric1],
-        "localhost:9778" : [http/client/roundtrip_latency],
+        "0.0.0.0:9777" : [http/server/server_latency, custom_metric1],
+        "0.0.0.0:9778" : [http/client/roundtrip_latency],
       }
       config:
         scrape_configs: