fix bool attribute equality

open-telemetry · Jul 21, 2021 · f895196 · f895196
1 parent f1d4497
commit f895196
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/model/pdata/common.go b/model/pdata/common.go
@@ -269,6 +269,10 @@ func (a AttributeValue) Equal(av AttributeValue) bool {
 		return a.orig.Value == av.orig.Value
 	}
 
+	if a.Type() != av.Type() {
+		return false
+	}
+
 	switch v := a.orig.Value.(type) {
 	case *otlpcommon.AnyValue_StringValue:
 		return v.StringValue == av.orig.GetStringValue()

diff --git a/model/pdata/common_test.go b/model/pdata/common_test.go
@@ -201,15 +201,15 @@ func TestAttributeValueEqual(t *testing.T) {
 	av1 = NewAttributeValueDouble(123)
 	assert.True(t, av1.Equal(av2))
 
-	av2 = NewAttributeValueBool(true)
+	av2 = NewAttributeValueBool(false)
 	assert.False(t, av1.Equal(av2))
 	assert.False(t, av2.Equal(av1))
 
 	av1 = NewAttributeValueBool(true)
-	assert.True(t, av1.Equal(av2))
+	assert.False(t, av1.Equal(av2))
 
 	av1 = NewAttributeValueBool(false)
-	assert.False(t, av1.Equal(av2))
+	assert.True(t, av1.Equal(av2))
 
 	av1 = NewAttributeValueArray()
 	av1.ArrayVal().AppendEmpty().SetIntVal(123)