Add support for TimeEncoding for Zap logger #10205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encoding explicitly Update newLogger to read and interpret the selected option
|
bogdandrutu
reviewed
May 23, 2024
Comment on lines
+96
to
+107
| // TimeEncoding controls the zap logger's time encoding | ||
| // Permitted values are: | ||
| // - "Epoch" | ||
| // - "EpochMillis" | ||
| // - "EpochNanos" | ||
| // - "ISO8601" | ||
| // - "RFC3339" | ||
| // - "RFC3339Nano" | ||
| // Leaving the value blank results in the default time encoding, which | ||
| // depends on the message encoding (for JSON, it will be EpochNanos, | ||
| // and for console, it will be ISO8601 | ||
| TimeEncoding string `mapstructure:"time_encoding"` |
There was a problem hiding this comment.
We would prefer not to derive from the zap.Config. Is this there already? if yes, can you add a link to confirm the name?
There was a problem hiding this comment.
Apologies, but I'm not following this. I wasn't able to find any mechanism by which I can set the Zap logger's time encoding through the existing telemetry config, hence the new field. One can only indirectly influence it (ex, by choosing console as the format), but there is no way to use, say, RFC3339 time encoding along with JSON formatted messages.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TimeEncodingfield underLogsConfigto control Zap logger time encoding explicitlynewLoggerto read and interpret the selected optionLink to tracking issue
Fixes #10204
Testing
None yet (wasn't able to find existing tests for
newLogger)Documentation
None yet (unsure where the docs for this live)