Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize module go.opentelemetry.io/collector/config/configtelemetry #10277

Open
7 of 8 tasks
atoulme opened this issue May 31, 2024 · 5 comments · Fixed by #11002
Open
7 of 8 tasks

Stabilize module go.opentelemetry.io/collector/config/configtelemetry #10277

atoulme opened this issue May 31, 2024 · 5 comments · Fixed by #11002

Comments

@atoulme
Copy link
Contributor

atoulme commented May 31, 2024

Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases (regardless of when this issue was opened):

  • No open issues or PRs in the module that would require breaking changes
  • No TODOs in the module code that would require breaking changes
  • No deprecated symbols in the module
  • No symbols marked as experimental in the module
  • The module follows the Coding guidelines

Please also make sure to publicly announce our intent to stabilize the module on:

  • The #otel-collector CNCF Slack Channel
  • The #opentelemetry CNCF Slack channel
  • A Collector SIG meeting (if unable to attend, just add to the agenda)

To help other people verify the above criteria, please link to the announcement and other links used to complete the above in a comment on this issue.

Once all criteria are met, close this issue by moving this module to the stable module set.

@atoulme
Copy link
Contributor Author

atoulme commented May 31, 2024

@jaronoff97
Copy link
Contributor

Prior to this package's stabilization, I would love it if there were more guidance on what each of the levels are for. Right now the documentation is very vague and I think the differences between normal & detailed are not specific enough. This is almost a flavor of #7543 where that metric could have been enabled only in the "detailed" configuration, however, reserving "detailed" that way wasn't an option because we put many metrics behind "detailed" that I would argue belong more in the "normal" or "basic" levels (ex of a detailed metric that IMO should be a "normal" metric).

@atoulme
Copy link
Contributor Author

atoulme commented May 31, 2024

@jaronoff97 opening #10286

@atoulme
Copy link
Contributor Author

atoulme commented Jun 5, 2024

Announced at SIG meeting 6/5.

@mx-psi
Copy link
Member

mx-psi commented Aug 1, 2024

I think we should solve #9510/#10769 before marking this stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

3 participants