Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default batch size potentially too large for OTLP exporter #1122

Closed
kbrockhoff opened this issue Jun 15, 2020 · 2 comments
Closed

Default batch size potentially too large for OTLP exporter #1122

kbrockhoff opened this issue Jun 15, 2020 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@kbrockhoff
Copy link
Member

Describe the bug
Correctness tests using golden dataset result in error when using the default batch process settings.

Steps to reproduce
Remove this line from correctness_test.go
send_batch_size: 1024

What did you expect to see?
Tests to pass.

What did you see instead?
grpc: received message larger than max (4987657 vs. 4194304)

What version did you use?
Version: 6dcfa47

What config did you use?
Config: See testbed/correctness/correctness_test.go

Environment
OS: OS X
Compiler(if manually compiled): go1.14.3 darwin/amd64

Additional context

@kbrockhoff kbrockhoff added the bug Something isn't working label Jun 15, 2020
@flands flands added this to the GA 1.0 milestone Jun 18, 2020
@bogdandrutu
Copy link
Member

@kbrockhoff the max message size can be configured https://github.com/open-telemetry/opentelemetry-collector/blob/master/config/configgrpc/configgrpc.go#L122 to a larger value if the intent is to support larger batches.

I think this works as expected, gRPC otlp receiver respects the config. I would close this issue but feel free to reopen or start a new issue if this config is not enough.

@flands flands modified the milestones: GA 1.0, Beta 0.6.0 Jul 16, 2020
@cwegener
Copy link

For anyone who comes across this post and is wondering what "Line 122" in configgrpc.go actually refers to in Bogdan's comment.
It's this:

// MaxRecvMsgSizeMiB sets the maximum size (in MiB) of messages accepted by the server.
MaxRecvMsgSizeMiB uint64 `mapstructure:"max_recv_msg_size_mib"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants