Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: use dynamic endpoint/port even when reading config files #309

Closed
pjanotti opened this issue Aug 29, 2019 · 1 comment
Closed

Test: use dynamic endpoint/port even when reading config files #309

pjanotti opened this issue Aug 29, 2019 · 1 comment

Comments

@pjanotti
Copy link
Contributor

Some tests, eg.: service_test.go, load configuration from an yaml file. Currently this forces the usage of fixed endpoint/ports which can be problematic in certain test environments that already use these ports (or if a system running the test also collects telemetry data). It will be helpful to have place holders that will trigger the replacement of hard coded endpoint/ports from the yaml.

@bogdandrutu
Copy link
Member

you can use environment variables now #334 :)

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
…y#309)

Bumps [boto3](https://github.com/boto/boto3) from 1.17.53 to 1.17.54.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.17.53...1.17.54)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants