Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change batch processor to take client info into consideration #4544

Closed
jpkrohling opened this issue Dec 13, 2021 · 7 comments
Closed

Change batch processor to take client info into consideration #4544

jpkrohling opened this issue Dec 13, 2021 · 7 comments
Assignees
@jpkrohling
Labels
auth Authentication related

Comments

@jpkrohling
Copy link
Member

Currently, the client info is propagated down from receivers to other components as part of the incoming context. Some processors, like the batch, discard the context, building a new one. This issue is to add the possibility to group data points by client characteristics at the batch processor.
@jpkrohling jpkrohling self-assigned this Dec 13, 2021
@jpkrohling jpkrohling added the auth Authentication related label Dec 13, 2021
@bogdandrutu bogdandrutu mentioned this issue Jan 5, 2022
Open
@jpkrohling jpkrohling mentioned this issue Feb 9, 2022
Closed
@tigrannajaryan tigrannajaryan mentioned this issue Jun 27, 2022
Closed
6 tasks
@kovrus kovrus mentioned this issue Aug 2, 2022
Merged
@newly12 newly12 mentioned this issue Aug 4, 2022
Closed
@graemechristie
Copy link

Is there any progress on this ? Currently we cannot use the batch processor with the routing or header setter processors ... this seems a pretty essential feature for any scenarios involving headers or attributes ?

@jpkrohling
Copy link
Member Author

There hasn't been any progress on this yet.

@jdgeisler
Copy link

We are also wondering if there are any plans for this on the roadmap?

For Tempo, we are looking to dynamically set the tenant from a header or attribute like we do with Loki using the attribute hints, but without the batch processor the current solution with the headers_setter extension is not working well at scale.

@jmacd jmacd mentioned this issue Jan 18, 2023
Open
@jmacd jmacd mentioned this issue Mar 6, 2023
Closed
@jmacd jmacd mentioned this issue Apr 26, 2023
Merged
@AlexDCraig
Copy link

We would also really like this feature! It really impacts scalability

@jpkrohling
Copy link
Member Author

I understand this is only waiting on a maintainer to push the button.

cc @open-telemetry/collector-maintainers

@atoulme
Copy link
Contributor

atoulme commented May 19, 2023

#7578 is merged, can this issue be marked as completed?

@Yangningli

This comment was marked as resolved.

Sign in to view
@atoulme atoulme mentioned this issue Oct 5, 2023
Closed
@ptodev ptodev mentioned this issue Oct 6, 2023
Merged
jpkrohling added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Oct 24, 2023
@ptodev @jpkrohling
[headerssetter] Remove "Limitations" section from README. (#27465)
d50e094 
The docs for the `headers_setter` extension state that the
`from_context` config option does not work if the batch processor is
used. I believe this comment is out of date, because it seems that the
[PR](open-telemetry/opentelemetry-collector#7578)
linked to the
[issue](open-telemetry/opentelemetry-collector#4544)
has been merged. Note that I haven't tested that this actually works
with the header setter extension. Please let me know if you think
testing is necessary.

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this issue Oct 27, 2023
@ptodev @jpkrohling @sigilioso
[headerssetter] Remove "Limitations" section from README. (open-telem…
87f4d4d 
…etry#27465)

The docs for the `headers_setter` extension state that the
`from_context` config option does not work if the batch processor is
used. I believe this comment is out of date, because it seems that the
[PR](open-telemetry/opentelemetry-collector#7578)
linked to the
[issue](open-telemetry/opentelemetry-collector#4544)
has been merged. Note that I haven't tested that this actually works
with the header setter extension. Please let me know if you think
testing is necessary.

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@ptodev @jpkrohling @jmsnll
[headerssetter] Remove "Limitations" section from README. (open-telem…
bd11a01 
…etry#27465)

The docs for the `headers_setter` extension state that the
`from_context` config option does not work if the batch processor is
used. I believe this comment is out of date, because it seems that the
[PR](open-telemetry/opentelemetry-collector#7578)
linked to the
[issue](open-telemetry/opentelemetry-collector#4544)
has been merged. Note that I haven't tested that this actually works
with the header setter extension. Please let me know if you think
testing is necessary.

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpkrohling jpkrohling

Labels
auth Authentication related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jpkrohling @atoulme @graemechristie @dmitryax @AlexDCraig @jdgeisler @Yangningli