Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove export_resource_labels flag from Zipkin exporter #595

Closed
pmm-sumo opened this issue Mar 5, 2020 · 0 comments
Closed

Remove export_resource_labels flag from Zipkin exporter #595

pmm-sumo opened this issue Mar 5, 2020 · 0 comments
Assignees
@flands
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone
Beta 0.5.0

Comments

@pmm-sumo
Copy link
Contributor

pmm-sumo commented Mar 5, 2020

The flag was added so the users could keep the previous behaviour of Zipkin exporter, though it's not symmetric and should be actually removed.

Lets give the users time until ~ April '20 and then remove the flag completely

Background: #591 (comment)
@pmm-sumo pmm-sumo mentioned this issue Mar 5, 2020
Merged
@tigrannajaryan tigrannajaryan added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label May 13, 2020
flands added a commit to flands/opentelemetry-collector that referenced this issue Jun 22, 2020
@flands
Remove export_resource_labels flag from Zipkin exporter
b5e335a 
Addresses open-telemetry#595
@flands flands added this to the Beta 0.5 milestone Jun 22, 2020
@flands flands mentioned this issue Jun 22, 2020
Closed
@flands flands self-assigned this Jun 22, 2020
flands added a commit to flands/opentelemetry-collector that referenced this issue Jun 23, 2020
@flands
Remove export_resource_labels flag from Zipkin exporter
e96248a 
Addresses open-telemetry#595
@flands flands mentioned this issue Jun 23, 2020
Merged
tigrannajaryan pushed a commit that referenced this issue Jun 23, 2020
@flands
[BREAKING CHANGE] Remove export_resource_labels flag from Zipkin ex…
c108cef 
…porter (#1163)

Addresses #595

This flag was scheduled to be removed. Removing now.
@flands flands closed this as completed Jun 28, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this issue Jul 13, 2020
@flands @wyTrivail
[BREAKING CHANGE] Remove export_resource_labels flag from Zipkin ex…
5393f1a 
…porter (open-telemetry#1163)

Addresses open-telemetry#595

This flag was scheduled to be removed. Removing now.
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@jmacd @lizthegrey
Remove Labelset (open-telemetry#595)
e8546e3 
* Remove LabelSet frmo api/metric

* SDK tests pass

* Restore benchmarks

* All tests pass

* Remove all mentions of LabelSet

* Test RecordBatch

* Batch test

* Improves benchmark (some)

* Move the benchmark to match HEAD

* Align labels for GOARCH=386

* Add alignment test

* Disable the stress test fo GOARCH=386

* Fix bug

* Move atomic fields into their own file

* Add a TODO

* Comments

* Remove metric.Labels(...)

* FTB

Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@jeffreyc-splunk
Update docs for SA platform support (open-telemetry#595)
c029218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flands flands

Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
Beta 0.5.0
Development

No branches or pull requests
3 participants
@flands @tigrannajaryan @pmm-sumo