Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize module confignet #9045

Open
8 tasks done
Tracked by #9375
codeboten opened this issue Dec 5, 2023 · 12 comments
Open
8 tasks done
Tracked by #9375

Stabilize module confignet #9045

codeboten opened this issue Dec 5, 2023 · 12 comments

Comments

@codeboten
Copy link
Contributor

codeboten commented Dec 5, 2023

Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases:

  • No open issues or PRs in the module that would require breaking changes
  • No TODOs in the module code that would require breaking changes
  • No deprecated symbols in the module
  • No symbols marked as experimental in the module
  • The module follows the Coding guidelines

Please also make sure to publicly announce our intent to stabilize the module on:

  • The #otel-collector CNCF Slack Channel
  • The #opentelemetry CNCF Slack channel
  • A Collector SIG meeting (if unable to attend, just add to the agenda)

To help other people verify the above criteria, please link to the announcement and other links used to complete the above in a comment on this issue.

Once all criteria are met, close this issue by moving this module to the stable module set.

@codeboten
Copy link
Contributor Author

This is the PR to mark confignet as stable #7954

@codeboten
Copy link
Contributor Author

codeboten commented Dec 7, 2023

Open issues regarding confignet:

@codeboten codeboten self-assigned this Dec 7, 2023
@dmitryax
Copy link
Member

dmitryax commented Dec 7, 2023

I think we should have 1.0 milestones for each module that we want to release as 1.0 so we can include all the issues there

@codeboten
Copy link
Contributor Author

@dmitryax created the milestone and added issues to it

@mx-psi
Copy link
Member

mx-psi commented Dec 15, 2023

@codeboten I think it would be helpful to have links as in #8978 so that right before marking as 1.0 one can quickly check that we did not accidentally introduce any new TODOs or experimental symbols

@atoulme
Copy link
Contributor

atoulme commented Dec 19, 2023

We need to address the new comments in #7954 as well.

@mx-psi
Copy link
Member

mx-psi commented Dec 20, 2023

Filed #9159 to add this to coding guidelines

@atoulme
Copy link
Contributor

atoulme commented Jan 10, 2024

I see the comments in #7954 have been acted upon with #9105 - can we move to announce stabilization intent, anything else left to consider?

@mx-psi
Copy link
Member

mx-psi commented Jan 10, 2024

Should we remove Context from the method names? (That is, effectively just add context.Context to the original methods?)

@mx-psi
Copy link
Member

mx-psi commented Jan 10, 2024

Should we remove Context from the method names? (That is, effectively just add context.Context to the original methods?)

We discussed this offline and decided that we should

@codeboten
Copy link
Contributor Author

See #9258

@codeboten
Copy link
Contributor Author

Blocked by the stabilization work for confmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

4 participants