Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout to confignet #4331

Closed
BinaryFissionGames opened this issue Nov 1, 2021 · 1 comment · Fixed by #9066
Closed

Add timeout to confignet #4331

BinaryFissionGames opened this issue Nov 1, 2021 · 1 comment · Fixed by #9066
Assignees
@TylerHelmuth
Milestone
go.opentelemetry....

Comments

@BinaryFissionGames
Copy link

Is your feature request related to a problem? Please describe.
When dialing, there should be a configurable timeout in these configs. Without these, no timeout is used and depending on the protocol and OS, may take a large amount of time to timeout or not timeout at all.

Describe the solution you'd like
Add a timeout parameter and use it with net.DialTimeout, allowing a configurable timeout when dialing.
@BinaryFissionGames BinaryFissionGames mentioned this issue Nov 1, 2021
Merged
@github-actions github-actions bot added the Stale label Nov 2, 2023
@codeboten codeboten mentioned this issue Dec 7, 2023
Open
8 tasks
@github-actions github-actions bot removed the Stale label Dec 9, 2023
@TylerHelmuth
Copy link
Member

Please assign this to me

@TylerHelmuth TylerHelmuth mentioned this issue Dec 11, 2023
Merged
bogdandrutu pushed a commit that referenced this issue Dec 19, 2023
@TylerHelmuth
[confignet] Add DialerTimeout config option (#9066)
920cf9d 
**Description:** 
Adds a new `dialer_timeout` config option to `confignet` to allow
configuring the timeout of the connection.

**Link to tracking Issue:** 
Closes
#4331

**Testing:** 
Added new unit tests

**Documentation:** 
Updated readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerHelmuth TylerHelmuth

Labels
None yet
Projects
Collector: v1
Status: Done
Milestone
go.opentelemetry.io/collector/config/...
Development

Successfully merging a pull request may close this issue.

[confignet] Add DialerTimeout config option TylerHelmuth/opentelemetry-collector
3 participants
@codeboten @BinaryFissionGames @TylerHelmuth