Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pdata] Inspect and update the pdata comments #9070

Open
dmitryax opened this issue Dec 11, 2023 · 1 comment
Open

[pdata] Inspect and update the pdata comments #9070

dmitryax opened this issue Dec 11, 2023 · 1 comment
Assignees
@berkeli
Labels
area:pdata pdata module related issues bug Something isn't working good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@dmitryax
Copy link
Member

dmitryax commented Dec 11, 2023 •
edited
Loading

Inspect all the pdata comments related to the invalid usage and update them if needed.

Similar to how it was resolved for pcommon.Value in #9025, do the same for other API parts.
@dmitryax dmitryax added bug Something isn't working help wanted Good issue for contributors to OpenTelemetry Service to pick up good first issue Good for newcomers area:pdata pdata module related issues labels Dec 11, 2023
@dmitryax dmitryax mentioned this issue Dec 11, 2023
Closed
@berkeli
Copy link
Contributor

berkeli commented Dec 13, 2023

I'm happy to look into this one

@berkeli berkeli mentioned this issue Dec 13, 2023
Merged
dmitryax pushed a commit that referenced this issue Feb 2, 2024
@berkeli
[chore] [pdata] update comments to make it clear which functions panic (
c5d86ce 
#9107)

**Description:** 
This updates comments and adds tests based on
#9070

**Link to tracking Issue:** #9070

**Testing:** This only updates comments, but I have added unit tests to
verify the behaviour described in comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berkeli berkeli

Labels
area:pdata pdata module related issues bug Something isn't working good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitryax @berkeli