Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize configopaque #9167

Closed
10 tasks done
Tracked by #9375
atoulme opened this issue Dec 21, 2023 · 6 comments · Fixed by #9427
Closed
10 tasks done
Tracked by #9375

Stabilize configopaque #9167

atoulme opened this issue Dec 21, 2023 · 6 comments · Fixed by #9427

Comments

@atoulme
Copy link
Contributor

atoulme commented Dec 21, 2023

Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases:

Edited by @mx-psi on 2023-01-12 to add three two more issues

Please also make sure to publicly announce our intent to stabilize the module on:

  • The #otel-collector CNCF Slack Channel
  • The #opentelemetry CNCF Slack channel
  • A Collector SIG meeting (if unable to attend, just add to the agenda)

To help other people verify the above criteria, please link to the announcement and other links used to complete the above in a comment on this issue.

Once all criteria are met, close this issue by moving this module to the stable module set.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 2, 2024

Added to agenda of SIG meeting on Jan 3, 2024: https://docs.google.com/document/d/1r2JC5MB7GupCE7N32EwGEXs9V_YIsPgoFiLP4VWVMkE/edit

@atoulme
Copy link
Contributor Author

atoulme commented Jan 2, 2024

@mx-psi
Copy link
Member

mx-psi commented Jan 3, 2024

We should think about redacting also on String method based on the discussion on open-telemetry/opentelemetry-collector-contrib#29446 (comment). I have not looked into this but I think it's a good idea.

cc @codeboten @martin-majlis-s1

@atoulme
Copy link
Contributor Author

atoulme commented Jan 3, 2024

I have opened #9213 to follow up.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 11, 2024

I am not aware of any other work needing to take place on this package ; please speak up if you see anything else worth addressing.
In particular, I have reviewed the code and have found that it matches coding best practices, but a more experienced reviewer should do another pass.
If everything is squared away, then this package can be considered stable in 2 minor releases, after 0.94.0 is out.

@mx-psi
Copy link
Member

mx-psi commented Jan 12, 2024

I did another pass and filed #9271 so that we also redact the output when using %#v and have a bit more thorough tests.

Two remaining issues IMO:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants