[configtls] Validate MinVersion and MaxVersion

[mx-psi]

We effectively restrict the allowed versions to the set defined here:

opentelemetry-collector/config/configtls/configtls.go

Line 382 in f5a7315

var tlsVersions = map[string]uint16{

We should validate for it! This can be done after 1.0 per the rules we have here

opentelemetry-collector/VERSIONING.md

Lines 52 to 54 in f5a7315

	* **Making validation rules more strict**. A valid configuration struct as defined by its `Validate` method return value
	must continue to be valid after a change to the validation rules, except when the configuration struct would cause an error
	on its intended usage (e.g. when calling a method or when passed to any method or function in any module under opentelemetry-collector).

Still, it would be nice to have before 1.0 IMO

[molejnik88]

Hi,
Isn't MinVersion validated here: configtls.go#L176 and MaxVersion validated here: configtls.go#L180?

Do we want to call LoadTLSConfig in respective components' config.Validate() methods?

[TylerHelmuth]

@molejnik88 we should add a Validate function to TLSSetting. When a component's config uses TLSSetting and Validate is called for the component's config, it will also call TLSSetting's Validate.

[yurishkuro]

When a component's config uses TLSSetting and Validate is called for the component's config, it will also call TLSSetting's Validate.

@TylerHelmuth are you saying this would be automatic, or does each config's Validate need to call TLSSettings.Validate() explicitly?

[TylerHelmuth]

As long as I am reading this correctly, it is automatic. The component framework will call validate on the entire config, which ends up making Validate calls on anything it can within the config struct.

[molejnik88]

I'd like to work on this issue. Can you please assign it to me?

[atoulme]

Done, go for it