New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[configrpc] Remove SanitizedEndpoint
?
#9482
Comments
I think we need to reconsider removing this feature. #9616 showed the otlpexporter relies on it. We could reproduce the functionality directly in the otlpexporter, but leaving it in configgrpc seems ok as well. |
@TylerHelmuth Do we have more than one usage of this function? If not, I would vote to move this to the OTLP exporter |
@mx-psi it has been used in configgrpc's |
The OTLP exporter has another way to deal with sanitized endpoint by stripping the scheme of the URL at unmarshaling time. OK, so for this to happen:
|
For the usage within |
@TylerHelmuth As you said, I don't think uses on |
**Description:** <Describe what has changed.> Deprecates `configgrpc.SanitizedEndpoint()`. **Link to tracking Issue:** <Issue number if applicable> Works towards: #9482
As far as I can tell, this function is not used by any code, either in core or contrib. Should we remove it?
The text was updated successfully, but these errors were encountered: