Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confighttp] Update public methods to accept context.Context #9807

Closed
Tracked by #9490
TylerHelmuth opened this issue Mar 21, 2024 · 9 comments · Fixed by #10138
Closed
Tracked by #9490

[confighttp] Update public methods to accept context.Context #9807

TylerHelmuth opened this issue Mar 21, 2024 · 9 comments · Fixed by #10138
Assignees
@AkhigbeEromo
Labels
area:config
Milestone
go.opentelemetry....

Comments

@TylerHelmuth
Copy link
Member

No description provided.

@TylerHelmuth TylerHelmuth mentioned this issue Mar 21, 2024
Open
9 tasks
@TylerHelmuth TylerHelmuth changed the title confighttp [confighttp] Update public methods to accept context.Context Mar 21, 2024
@AkhigbeEromo
Copy link
Contributor

Hello @TylerHelmuth can this issue be assigned to me?

And also just to confirm what I am working on, the public functions in this package are:

  • ToClient
  • ToListener
  • ToServer

@TylerHelmuth
Copy link
Member Author

@AkhigbeEromo I agree that those are 3 three functions to add context to.

@AkhigbeEromo
Copy link
Contributor

Okay @TylerHelmuth , i will start working on this issue.

Can it be assigned to me?

This was referenced Mar 29, 2024
Closed
Merged
codeboten pushed a commit that referenced this issue Apr 5, 2024
@AkhigbeEromo
Updated public methods in confighttp (#9895)
79ccf55 
Added context.Context to the following functions:

ToClient
ToServer
ToListener
Link:
#9807
@codeboten
Copy link
Contributor

Closed by #9895

@TylerHelmuth TylerHelmuth reopened this Apr 5, 2024
@TylerHelmuth
Copy link
Member Author

TylerHelmuth commented Apr 5, 2024 •
edited

This isn't complete until we go through the deprecation cycle. We need to:

  • Wait for the Release v0.98.0
  • Rename the To*Context functions to To* by deprecating the To*Context versions and adding context.Context to the To* versions.
  • Wait for the v0.99.0 release
  • Remove the deprecated To*Context functions.

@AkhigbeEromo
Copy link
Contributor

Is there anything i will need to do? @TylerHelmuth

@codeboten
Copy link
Contributor

@TylerHelmuth fair enough, apologies for closing too eagerly

@TylerHelmuth
Copy link
Member Author

@AkhigbeEromo yup, over the next 2 release cycles you can work on those tasks I listed out. For now we wait for the next release.

@AkhigbeEromo
Copy link
Contributor

Understood, Thank you @TylerHelmuth

@codeboten codeboten mentioned this issue Apr 11, 2024
Merged
codeboten added a commit that referenced this issue Apr 12, 2024
@codeboten
[confighttp] deprecate ToClientContext, ToServerContext, ToListenerCo…
c8666b8 
…ntext (#9944)

Replaced by ToClient, ToServer, ToListener

Related to #9807

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@TylerHelmuth TylerHelmuth mentioned this issue May 10, 2024
Merged
mx-psi pushed a commit that referenced this issue May 13, 2024
@TylerHelmuth
[confighttp] Remove deprecated functions (#10138)
671dcbc 
Closes
#9807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AkhigbeEromo AkhigbeEromo

Labels
area:config
Projects
Collector: v1
Status: Done
Milestone
go.opentelemetry.io/collector/configh...
Development

Successfully merging a pull request may close this issue.

[confighttp] Remove deprecated functions TylerHelmuth/opentelemetry-collector
3 participants
@codeboten @TylerHelmuth @AkhigbeEromo