Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[configtls] Update public methods to accept context.Context #9811

Open
Tracked by #9490
TylerHelmuth opened this issue Mar 21, 2024 · 1 comment
Open
Tracked by #9490

[configtls] Update public methods to accept context.Context #9811

TylerHelmuth opened this issue Mar 21, 2024 · 1 comment
Labels
area:config
Milestone
go.opentelemetry....

Comments

@TylerHelmuth
Copy link
Member

No description provided.

@TylerHelmuth TylerHelmuth mentioned this issue Mar 21, 2024
Open
9 tasks
@TylerHelmuth
Copy link
Member Author

There are currently 3 public functions in configtls:

  • ServerConfig.LoadTLSConfig
  • ClientConfig.LoadTLSConfig
  • Config.Validate

Validate doesn't qualify for the issue since it needs to conform to the ConfigValidator interface.

@TylerHelmuth TylerHelmuth mentioned this issue Mar 21, 2024
Merged
mx-psi pushed a commit that referenced this issue Mar 27, 2024
@TylerHelmuth @andrzej-stencel
[configtls] Add context.Context to public functions (#9813)
407ea43 
**Description:**
Opening this PR to prompt discussion about `configtls` and
`context.Context`.

We could add `context.Context` to these public functions and go through
the long deprecation/rename process, but I want to make sure it is
valuable.

Arguments against this PR:
- There isn't anything within these functions that currently rely on a
`context.Context`.
- There isn't anything inside these functions interact with the network.

Arguments in favor of this PR:
- Interacts with filesystem.
- Go best practice to allow passing context.

**Link to tracking Issue:** 
Related to
#9811

---------

Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
@TylerHelmuth TylerHelmuth mentioned this issue Apr 11, 2024
Merged
codeboten pushed a commit that referenced this issue Apr 15, 2024
@TylerHelmuth
[configtls] Deprecate *Context funcs (#9945)
282a594 
Works towards
#9811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:config
Projects
Collector: v1
Status: Todo
Milestone
go.opentelemetry.io/collector/config/...
Development

No branches or pull requests
1 participant
@TylerHelmuth