Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pipeline type validation #10078

Merged

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented May 3, 2024

Description

This PR reverts the change made in #9257 due to problems reported in #10031.

Link to tracking issue

Fixes #10031.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (109173d) to head (cf32936).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10078      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         360      360              
  Lines       16730    16717      -13     
==========================================
- Hits        15371    15359      -12     
+ Misses       1021     1020       -1     
  Partials      338      338              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth
Copy link
Member

@ycombinator please add a changelog entry

@mx-psi mx-psi added the release:blocker The issue must be resolved before cutting the next release label May 3, 2024
@bogdandrutu bogdandrutu merged commit 67d3718 into open-telemetry:main May 3, 2024
65 checks passed
@github-actions github-actions bot added this to the next release milestone May 3, 2024
@ycombinator ycombinator deleted the revert-validate-pipeline-types branch May 3, 2024 22:18
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this pull request May 27, 2024
#### Description

This PR reverts the change made in
open-telemetry#9257 due
to problems reported in
open-telemetry#10031.

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes open-telemetry#10031.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otelcol.Collector.DryRun() now instantiates all components
4 participants