Add consumer profiles #10464
Merged
Add consumer profiles #10464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10464 +/- ##
=======================================
Coverage 92.33% 92.34%
=======================================
Files 393 395 +2
Lines 18647 18656 +9
=======================================
+ Hits 17218 17227 +9
Misses 1069 1069
Partials 360 360 ☔ View full report in Codecov by Sentry. |
dmathieu
force-pushed
the
profiles-consumer
branch
2 times, most recently
from
efa1a89
to
08d4ba8
Compare
dmathieu
force-pushed
the
profiles-consumer
branch
from
45ca9a7
to
c3a88fa
Compare
|
I believe the failure is unrelated to these changes. |
mx-psi
reviewed
Jul 1, 2024
dmathieu
force-pushed
the
profiles-consumer
branch
from
8bcef67
to
fe7cd2c
Compare
dmathieu
force-pushed
the
profiles-consumer
branch
from
5a0108c
to
21912e4
Compare
mx-psi
reviewed
Jul 2, 2024
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
LGTM. Since this is the first PR actually adding implementation for profiles after the RFC, I am going to wait a few days to let other @open-telemetry/collector-approvers chime in
For future modules, it would be great to split changes of internal-only changes and new modules into separate PRs
|
@open-telemetry/collector-approvers planning to merge this tomorrow if nobody blocks before then |
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jul 9, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This adds profiles support for consumers. <!-- Issue number if applicable --> #### Link to tracking issue Based on the discussion in open-telemetry#10375. --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds profiles support for consumers.
Link to tracking issue
Based on the discussion in #10375.