Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move receiver into an internal package, in preparation for profiles #10530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jul 3, 2024

Description

This splits the receiver package, so the APIs are in an internal package, and redefined publicly for logs/metrics/traces.
In preparation for adding profiles to the package.

Link to tracking issue

See #10375

cc @mx-psi

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 98.90110% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.40%. Comparing base (9405cfe) to head (7409c0a).

Files Patch % Lines
receiver/internal/factory.go 97.77% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10530   +/-   ##
=======================================
  Coverage   92.39%   92.40%           
=======================================
  Files         393      395    +2     
  Lines       18614    18622    +8     
=======================================
+ Hits        17199    17207    +8     
  Misses       1058     1058           
  Partials      357      357           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu marked this pull request as ready for review July 3, 2024 14:02
@dmathieu dmathieu requested a review from a team as a code owner July 3, 2024 14:02
@dmathieu dmathieu requested a review from dmitryax July 3, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant