Add the ability to batch metrics as a processor. #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccaraman
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1060 +/- ##
==========================================
+ Coverage 86.33% 86.41% +0.07%
==========================================
Files 199 199
Lines 14072 14153 +81
==========================================
+ Hits 12149 12230 +81
- Misses 1461 1463 +2
+ Partials 462 460 -2
Continue to review full report at Codecov.
|
bogdandrutu
changed the title
bogdandrutu
reviewed
Jun 1, 2020
| // | ||
| // Batches are sent out with any of the following conditions: | ||
| // - batch size reaches cfg.SendBatchSize | ||
| // - cfg.Timeout is elapsed since the timestamp when the previous batch was sent out. | ||
| // - cfg.Timeout is elapsed since the timestamp when the previous batchTraces was sent out. |
| } | ||
|
|
||
| func (bp *batchMetricProcessor) GetCapabilities() component.ProcessorCapabilities { | ||
| return component.ProcessorCapabilities{MutatesConsumedData: true} |
There was a problem hiding this comment.
Please add an issue to discuss if this is needed. Not sure if we "mutate" data.
|
@ccaraman please also ensure that the diff coverage is over the limit :) |
bogdandrutu
approved these changes
Jun 2, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
* Add batching for metrics * Update documentation * Improve test coverage
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…#1060) * Move `api/label` to `label` * Move `api/kv` package contents into `label` package * Unify label package name * Move `api/internal/rawhelpers.go` to `internal` * Propagate replacing `api/kv` with `label` pkg * golint * Fix over-aggressive change * Update Changelog
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#1060) Bumps [boto3](https://github.com/boto/boto3) from 1.20.25 to 1.20.26. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.20.25...1.20.26) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add the ability to batch metrics as a processor.
Link to tracking Issue: N/A
Testing: Added test for batching of metrics
Documentation: Updated the docs.