Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configgrpc] Send UNAUTHENTICATED on auth failure #10670

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jpkrohling
Copy link
Member

Fixes #7646

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Fixes open-telemetry#7646

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling requested a review from a team as a code owner July 19, 2024 16:13
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.38%. Comparing base (4b5f096) to head (5bd3861).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10670      +/-   ##
==========================================
+ Coverage   92.33%   92.38%   +0.05%     
==========================================
  Files         403      403              
  Lines       18734    18729       -5     
==========================================
+ Hits        17298    17303       +5     
+ Misses       1076     1066      -10     
  Partials      360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should return something like INTERNAL when we get a 404 or 5xx status code from the auth server in cases where the issue is on the Collector's side and not anything related to the caller. But I don't see any good way to do that right now, and this aligns with how the HTTP interceptor works, so LGTM.

@mx-psi mx-psi merged commit 49ea32b into open-telemetry:main Jul 24, 2024
52 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otlpreceiver is not throwing a valid gRPC Status for successful scenarios or authentication-related errors
6 participants