Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiles support in processor #10691

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jul 22, 2024

Description

This follows #10526, and adds profiles support into processors.

Link to tracking issue

See #10375

cc @mx-psi

@dmathieu dmathieu force-pushed the processorprofiles branch 5 times, most recently from 48d250a to 62515d0 Compare July 22, 2024 09:42
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.19%. Comparing base (8b5e231) to head (573aa89).
Report is 6 commits behind head on main.

Files Patch % Lines
processor/internal/factory.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10691      +/-   ##
==========================================
- Coverage   92.39%   92.19%   -0.20%     
==========================================
  Files         403      404       +1     
  Lines       18739    18733       -6     
==========================================
- Hits        17313    17270      -43     
- Misses       1066     1108      +42     
+ Partials      360      355       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu force-pushed the processorprofiles branch 2 times, most recently from c5d6b9f to b675147 Compare July 22, 2024 10:06
@dmathieu dmathieu marked this pull request as ready for review July 22, 2024 10:19
@dmathieu dmathieu requested a review from a team as a code owner July 22, 2024 10:19
@dmathieu dmathieu requested a review from codeboten July 22, 2024 10:19
@dmathieu
Copy link
Member Author

Moving back to draft pending #10692 (which will reduce the size of this PR).

@dmathieu dmathieu marked this pull request as draft July 22, 2024 12:15
@dmathieu dmathieu marked this pull request as ready for review July 23, 2024 13:06
@dmathieu
Copy link
Member Author

This is ready for review again.

@mx-psi mx-psi added this to the Profiling support milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants