otlpexporter: send configured headers in request #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures the configured headers for the otlp exporter are sent in export requests to the backends.
codeboten
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 86.74% 86.73% -0.02%
==========================================
Files 201 201
Lines 14491 14494 +3
==========================================
+ Hits 12570 12571 +1
- Misses 1468 1470 +2
Partials 453 453
Continue to review full report at Codecov.
|
jmacd
approved these changes
Jun 17, 2020
|
would love to get this into nightlies as it's a blocker for me currently |
dmitryax
approved these changes
Jun 17, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
This change ensures the configured headers for the otlp exporter are sent in export requests to the backends.
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Convert XConfigure into constructors Previously, we discussed the possibility of converting the config types into internal ones. But due to the cyclic dependencies it introduces, we are only converting XConfigure into constructors and document that XConfig types are most likely are not going to be directly used by developers. In package documents, constructors will be nicely listed under the config types and they won't be yet another standalone symbol developers need to learn about. Fixes open-telemetry#1130. * Add the changes to the CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures the configured headers for the otlp exporter are sent in export requests to the backends.
Added a unit test to validate change works.
No documentation was added, the headers configuration option was already documented.