[BREAKING CHANGE] Add config settings for Http Client, change Zipkin to use it. #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
jrcamp
reviewed
Jun 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #1186 +/- ##
==========================================
- Coverage 87.58% 87.57% -0.01%
==========================================
Files 203 204 +1
Lines 14561 14573 +12
==========================================
+ Hits 12753 12763 +10
- Misses 1370 1371 +1
- Partials 438 439 +1
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
httpclient
branch
2 times, most recently
from
e1631d2
to
4455e2c
Compare
jrcamp
reviewed
Jun 24, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
flands
changed the title
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
3 tasks
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
Signed-off-by: Hui Kang <kangh@us.ibm.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change for Zipkin config "url" -> "endpoint", this makes it consistent with others.
Depends on #1184
Side effects: