Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to tune the read/write buffers for gRPC clients #1213

Merged
merged 2 commits into from Jun 26, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #1213 into master will decrease coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1213      +/-   ##
==========================================
- Coverage   88.08%   88.07%   -0.01%     
==========================================
  Files         203      203              
  Lines       14649    14658       +9     
==========================================
+ Hits        12903    12910       +7     
- Misses       1309     1310       +1     
- Partials      437      438       +1     
Impacted Files Coverage Δ
config/configgrpc/configgrpc.go 96.61% <84.61%> (-3.39%) ⬇️
exporter/jaegerexporter/factory.go 91.66% <100.00%> (+1.19%) ⬆️
exporter/opencensusexporter/factory.go 90.47% <100.00%> (+0.15%) ⬆️
exporter/otlpexporter/factory.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41dc4db...1f68823. Read the comment docs.

exporter/jaegerexporter/factory.go Show resolved Hide resolved
config/configgrpc/configgrpc.go Show resolved Hide resolved
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit f06d74d into open-telemetry:master Jun 26, 2020
@bogdandrutu bogdandrutu deleted the tunerwbuffer branch June 26, 2020 23:31
@flands flands added this to the Beta 0.5 milestone Jun 28, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
…#1213)

* Allow to tune the read/write buffers for gRPC clients

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Increase the memory size since we increased the write buffer size

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants