Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jaeger translations #1222

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Fix jaeger translations #1222

merged 4 commits into from
Jul 10, 2020

Conversation

kbrockhoff
Copy link
Member

Description: Fixed all translation diffs between OTLP and Jaeger

Link to tracking Issue: #815 #1137 #1160

Testing: All correctness tests now show zero diffs for OTLP, OpenCensus, Jaeger combinations

Documentation: N/A

@codecov
Copy link

codecov bot commented Jun 27, 2020

Codecov Report

Merging #1222 into master will decrease coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
- Coverage   88.60%   88.14%   -0.46%     
==========================================
  Files         207      203       -4     
  Lines       15110    14708     -402     
==========================================
- Hits        13388    12965     -423     
- Misses       1288     1305      +17     
- Partials      434      438       +4     
Impacted Files Coverage Δ
consumer/pdata/trace.go 100.00% <ø> (ø)
internal/goldendataset/span_generator.go 98.87% <100.00%> (+0.01%) ⬆️
translator/trace/jaeger/jaegerproto_to_traces.go 86.40% <100.00%> (+2.98%) ⬆️
translator/trace/jaeger/jaegerthrift_to_traces.go 90.99% <100.00%> (+0.08%) ⬆️
translator/trace/jaeger/traces_to_jaegerproto.go 84.55% <100.00%> (+2.37%) ⬆️
component/componenttest/nop_host.go 33.33% <0.00%> (-66.67%) ⬇️
component/componenttest/error_waiting_host.go 64.70% <0.00%> (-35.30%) ⬇️
receiver/otlpreceiver/metrics/otlp.go 72.72% <0.00%> (-27.28%) ⬇️
receiver/hostmetricsreceiver/factory.go 73.58% <0.00%> (-13.52%) ⬇️
...ceiver/hostmetricsreceiver/hostmetrics_receiver.go 73.52% <0.00%> (-11.72%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64403a6...36d90b5. Read the comment docs.

@tigrannajaryan tigrannajaryan added this to In progress in Collector via automation Jun 29, 2020
@flands flands added this to the Beta 0.5.1 milestone Jul 8, 2020
Collector automation moved this from In progress to Reviewer approved Jul 10, 2020
@bogdandrutu bogdandrutu merged commit e7ab219 into open-telemetry:master Jul 10, 2020
Collector automation moved this from Reviewer approved to Done Jul 10, 2020
@kbrockhoff kbrockhoff deleted the fix-jaeger-translations branch July 10, 2020 12:28
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
* fixed all Jaeger translation diffs from correctness tests

* fixed Jaeger translations where Resource is missing or empty

* improve test coverage
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#1222)

Bumps [boto3](https://github.com/boto/boto3) from 1.20.50 to 1.20.51.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.20.50...1.20.51)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants