Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added disk merged metric & updated tests #1267

Merged

Conversation

james-bebbington
Copy link
Member

Link to tracking Issue: #847

Description: Added disk merged metric (Linux only) & updated tests

@project-bot project-bot bot added this to In progress in Collector Jul 7, 2020
@james-bebbington james-bebbington changed the title Added disk merged metric for Linux & updated tests Added disk merged metric & updated tests Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1267 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
+ Coverage   89.41%   89.45%   +0.03%     
==========================================
  Files         211      212       +1     
  Lines       15017    15036      +19     
==========================================
+ Hits        13428    13451      +23     
+ Misses       1157     1155       -2     
+ Partials      432      430       -2     
Impacted Files Coverage Δ
...iver/internal/scraper/diskscraper/disk_metadata.go 100.00% <100.00%> (ø)
...eiver/internal/scraper/diskscraper/disk_scraper.go 96.36% <100.00%> (+3.77%) ⬆️
...internal/scraper/diskscraper/disk_scraper_linux.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 86.04% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4783107...2639e3a. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Jul 7, 2020
@bogdandrutu bogdandrutu merged commit 541edde into open-telemetry:master Jul 8, 2020
Collector automation moved this from Reviewer approved to Done Jul 8, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Renaming otcorrelations header to baggage

* Update CHANGELOG.md

* cleanup comment
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Co-authored-by: Tom Tan <Tom.Tan@microsoft.com>
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants