Remove report per cpu config option #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1326 +/- ##
==========================================
+ Coverage 89.60% 89.61% +0.01%
==========================================
Files 215 215
Lines 15185 15179 -6
==========================================
- Hits 13606 13603 -3
+ Misses 1151 1148 -3
Partials 428 428
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Jul 13, 2020
|
Not too much coverage improvements :) looks like testutils is going down. I think AssertDoubleMetricLabelDoesNotExist is not used anywhere now. |
bogdandrutu
approved these changes
Jul 13, 2020
Removed unused functions |
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove cpu scraper
report_per_cpuoption (this can be removed in metric transform processor instead). Also update tests & improve test coverage