Disable process scraper for any non Linux/Windows OS #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
bogdandrutu
approved these changes
Jul 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
+ Coverage 89.67% 89.69% +0.01%
==========================================
Files 215 214 -1
Lines 15124 15126 +2
==========================================
+ Hits 13563 13567 +4
+ Misses 1138 1137 -1
+ Partials 423 422 -1
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
process-non-supported-os
branch
from
dc34ed7
to
6829281
Compare
|
This is the highest I can possibly get coverage for this PR since coverage reports are Linux only |
bogdandrutu
approved these changes
Jul 13, 2020
|
Please rebase |
|
I closed this by mistake |
james-bebbington
force-pushed
the
process-non-supported-os
branch
from
6829281
to
55169b7
Compare
|
The build checks don't seem to be getting triggered, do I need to recreate this PR since it was closed? |
bogdandrutu
approved these changes
Jul 13, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…still read the response body. (open-telemetry#1328) * chore(zipkin-exporter): relay on the status code for the request but still read the response body. * fix(zipkin-exporter): fix tests. * chore(zipkin-exporter): adds changelog. * chore: 202 -> http.StatusAccepted Co-authored-by: Chris Bandy <bandy.chris@gmail.com> * chore: 202 -> http.StatusAccepted Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Chris Bandy <bandy.chris@gmail.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much of the process scraper functionality is not supported on non Linux/Windows OSs, or is implemented poorly, e.g. this was taking about 15s to complete on my Macbook. Have opted to explicitly disable the scraper on any other OS.
Also fixed issue where an error wasn't returned on initialization in one case and added a test for this.
Fixes #958