Convert Zipkin receiver and exporter to use OTLP and fix translation bugs #1446
Conversation
kbrockhoff
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
receiver/hostmetricsreceiver/internal/scraper/processscraper/process.go
Outdated
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper_test.go
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1446 +/- ##
==========================================
- Coverage 91.35% 91.25% -0.11%
==========================================
Files 240 246 +6
Lines 16754 17270 +516
==========================================
+ Hits 15305 15759 +454
- Misses 1045 1094 +49
- Partials 404 417 +13
Continue to review full report at Codecov.
|
|
Seems that correctness tests for Zipkin translation are failing |
|
Timestamps are not converting correctly on Linux but are on OS X. I am working on debugging. |
|
Can be some time zone issue, it is just a guess |
| b[i], b[j] = b[j], b[i] | ||
| } | ||
|
|
||
| // V2SpansToInternalTraces translates Zipkin v2 spans into internal trace data. |
There was a problem hiding this comment.
It doesn't appear that this method shares any implementation details with the Zipkin v1, can we keep them somewhat unified? I had just merged them together recently #1002
| return err | ||
| } | ||
|
|
||
| func populateSpanStatus(tags map[string]string, status pdata.SpanStatus) { |
There was a problem hiding this comment.
The previous implementation used statusMapper to infer the status from additional tags like http.status_code https://github.com/open-telemetry/opentelemetry-collector/blob/master/translator/trace/zipkin/zipkinv2_to_protospan.go#L239-L252
There was a problem hiding this comment.
Status is going to be removed from the specification. We should wait until that happens to revise this.
kbrockhoff
changed the title
Description: New translators were created for Zipkin formats to OTLP and for OTLP to Zipkin v2. The Zipkin receiver and exporter were converted to use the new translators.
Link to tracking Issue:
Fixes #526
Fixes #572
Fixes #1138
Fixes #1303
Fixes #1304
Testing: All existing tests pass
Documentation: N/A