Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension factory helper similar with other components #1485

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #1485 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1485      +/-   ##
==========================================
+ Coverage   91.26%   91.28%   +0.01%     
==========================================
  Files         239      240       +1     
  Lines       16689    16723      +34     
==========================================
+ Hits        15231    15265      +34     
  Misses       1048     1048              
  Partials      410      410              
Impacted Files Coverage Δ
exporter/exporterhelper/factory.go 100.00% <ø> (ø)
processor/processorhelper/factory.go 100.00% <ø> (ø)
receiver/receiverhelper/factory.go 100.00% <ø> (ø)
extension/extensionhelper/factory.go 100.00% <100.00%> (ø)
extension/fluentbitextension/factory.go 100.00% <100.00%> (ø)
extension/fluentbitextension/process.go 92.45% <100.00%> (ø)
extension/healthcheckextension/factory.go 100.00% <100.00%> (ø)
...nsion/healthcheckextension/healthcheckextension.go 92.85% <100.00%> (ø)
extension/pprofextension/factory.go 89.47% <100.00%> (+1.97%) ⬆️
extension/pprofextension/pprofextension.go 62.50% <100.00%> (-1.50%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b55cb6...e2b55d1. Read the comment docs.

exporter/exporterhelper/factory.go Outdated Show resolved Hide resolved
extension/extesionhelper/factory.go Outdated Show resolved Hide resolved
extension/extesionhelper/factory.go Outdated Show resolved Hide resolved
extension/extesionhelper/factory.go Outdated Show resolved Hide resolved
extension/extesionhelper/factory.go Outdated Show resolved Hide resolved
extension/extesionhelper/factory.go Outdated Show resolved Hide resolved
extension/extesionhelper/factory_test.go Outdated Show resolved Hide resolved
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Collector automation moved this from In progress to Reviewer approved Aug 5, 2020
@bogdandrutu bogdandrutu merged commit c8e28ed into open-telemetry:master Aug 6, 2020
Collector automation moved this from Reviewer approved to Done Aug 6, 2020
@bogdandrutu bogdandrutu deleted the extensionhelper branch August 6, 2020 00:24
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants