Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unconvert, remove unnecessary type conversions #1501

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu changed the title Enale unconvert, remove unnecessary type conversions Enable unconvert, remove unnecessary type conversions Aug 5, 2020
@project-bot project-bot bot added this to In progress in Collector Aug 5, 2020
Collector automation moved this from In progress to Reviewer approved Aug 5, 2020
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #1501 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
- Coverage   91.14%   91.13%   -0.02%     
==========================================
  Files         239      239              
  Lines       16787    16787              
==========================================
- Hits        15301    15299       -2     
- Misses       1062     1063       +1     
- Partials      424      425       +1     
Impacted Files Coverage Δ
receiver/otlpreceiver/otlp.go 91.66% <0.00%> (-2.78%) ⬇️
translator/internaldata/resource_to_oc.go 87.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b25af7...e321e47. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 51395f9 into open-telemetry:master Aug 5, 2020
Collector automation moved this from Reviewer approved to Done Aug 5, 2020
@bogdandrutu bogdandrutu deleted the enablecheck branch August 5, 2020 18:49
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…n-telemetry#1501)

* Reverse order of attribute precedence when merging two Resources

This reflects a change in the specification itself.
open-telemetry/opentelemetry-specification#1345

* Resolves open-telemetry#1500

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants