Adds a new config StartTimeMetricRegex #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weil0ng
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
|
|
|
PTAL @nilebox :) |
nilebox
reviewed
Aug 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
=======================================
Coverage 91.35% 91.36%
=======================================
Files 240 240
Lines 16744 16754 +10
=======================================
+ Hits 15297 15307 +10
Misses 1044 1044
Partials 403 403
Continue to review full report at Codecov.
|
nilebox
approved these changes
Aug 7, 2020
|
@Weil0ng please rebase on master and resolve conficts, and fix lint errors (https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector/2515/workflows/b3646cf6-0f32-4df5-8ddd-f2ca8a678c6d/jobs/21673) |
|
Lint errors still present. |
Previously the prometheus receiver only accepts `process_start_time_metric` as the start time when UseStartTimeMetric is set. For applications that export similar metrics but with a prefix, e.g., via NewProcessCollector(namespace), the receiver would drop such metrics. By adding StartTimeMetricRegex, at least we will be able to cover such use cases.
|
PTAL |
|
contrib-test error seems unrelated to this PR? |
|
@nilebox @bogdandrutu PTAL, thanks! |
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
(open-telemetry#1511) Co-authored-by: Lalit Kumar Bhasin <labhas@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the prometheus receiver only accepts
process_start_time_metricas the start time when UseStartTimeMetric isset. For applications that export similar metrics but with a prefix,
e.g., via NewProcessCollector(namespace), the receiver would drop such
metrics.
By adding StartTimeMetricRegex, at least we will be able to cover such
use cases.
related: #969
Testing: Adds new unit tests and end-to-end test case in prometheus receiver.
Documentation: none.