Breaking Change: Remove usage of ocagent package for oc exporter #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
bogdandrutu
changed the title
bogdandrutu
force-pushed
the
ocagent
branch
4 times, most recently
from
8cd1ee5
to
0681d78
Compare
Codecov Report
@@ Coverage Diff @@
## master #1516 +/- ##
==========================================
+ Coverage 91.57% 91.85% +0.28%
==========================================
Files 254 254
Lines 17472 17452 -20
==========================================
+ Hits 16000 16031 +31
+ Misses 1060 1014 -46
+ Partials 412 407 -5
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
ocagent
branch
9 times, most recently
from
db1879d
to
c85ea21
Compare
| // Cannot use WaitForReady in the calls because we don't have a "deadline" | ||
| // set for every message, tradeoff to use streaming, also does not help with | ||
| // individual messages. So to achieve something similar, we block to ensure we connect. | ||
| if cfg.WaitForReady { |
There was a problem hiding this comment.
So this means if WaitForReady=true and we cannot connect then startup will be aborted, right? Is this an expected behavior?
There was a problem hiding this comment.
Removed for the moment. Will think about this and add later, was mostly useful for some tests, but don't have to support it now.
bogdandrutu
force-pushed
the
ocagent
branch
4 times, most recently
from
57dd701
to
c813dfc
Compare
| if oce.tracesClients != nil { | ||
| // First remove all the clients from the channel. | ||
| for i := 0; i < oce.cfg.NumWorkers; i++ { | ||
| <-oce.tracesClients |
There was a problem hiding this comment.
Should we also honor cancellation context?
tigrannajaryan
approved these changes
Aug 17, 2020
bogdandrutu
force-pushed
the
ocagent
branch
2 times, most recently
from
761d8d5
to
bbc9452
Compare
The config for OpenCensus exporter removed . Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config for OpenCensus exporter removed
reconnection_delay.